Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryAdds inline previews for referenced table rows, backed by bounded table-name queries and on-demand schema and row loading.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/reference-row-preview.tsx | Implements the inline referenced-row preview and includes the completed normal-weight header fix. |
| apps/sim/hooks/queries/tables.ts | Adds bounded table-name and on-demand reference-row queries with refresh and local-mutation invalidation behavior consistent with the documented snapshot semantics. |
| apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx | Integrates reference-cell expansion and preview state into the virtualized table grid. |
| apps/sim/lib/table/application/bulk.ts | Batches reference-graph handling for explicit table deletion while preserving archive ordering and cycle rejection. |
| apps/sim/app/api/table/names/route.ts | Exposes the authenticated lightweight table-name projection through the standard internal route framework. |
Reviews (7): Last reviewed commit: "fix(tables): reject incomplete folder co..." | Re-trigger Greptile
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Confidence score: 4/5
- In
cell-render.tsx, double-clicking a reference chip can also trigger the cell’s inline edit mode after opening the preview, creating conflicting interactions; stopdblclickpropagation on the chip to match URL cell behavior.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/cell-render.tsx">
<violation number="1" location="apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/cell-render.tsx:409">
P2: Double-clicking a reference chip still bubbles `dblclick` to the cell, so opening the preview can also enter inline edit mode. Stop double-click propagation on the chip, matching the URL cell behavior.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
bc7186a to
e4ded13
Compare
e4ded13 to
a3d2126
Compare
a3d2126 to
5eef2b1
Compare
5eef2b1 to
2921222
Compare
2921222 to
2deec54
Compare
2deec54 to
1b145fe
Compare
1b145fe to
b4cbd5e
Compare
|
@cubic-dev-ai review this PR |
@j15z I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 47 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Re-trigger cubic
f65a221 to
815b6c3
Compare
815b6c3 to
e014a54
Compare
e014a54 to
503183e
Compare
503183e to
028729e
Compare
028729e to
34322d6
Compare
Chat and Home render the table grid inline, so the preview component, its query module, the referenced-by warning hook and the referrers lookup land in their graphs too — five modules the feature genuinely ships, not a barrel dragging code in. Only the three entries this branch actually grows are re-recorded; the rest keep their existing numbers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Summary
Type of Change
Testing
bun run type-check,bun run lint,bun run check:audits(45 audits),bun run check:react-query,bun run check:client-boundaryChecklist
Screenshots/Videos
Not attached — the delete dialogs and both preview states were exercised locally against a dev workspace.